Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include actual_rhs.H for new network implementation #2534

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Don't include actual_rhs.H for new network implementation #2534

merged 6 commits into from
Aug 9, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

actual_rhs.H is just a stub for already-converted networks so it would be good to be able to remove it.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review August 9, 2023 17:04
@zingale zingale merged commit 76295aa into AMReX-Astro:development Aug 9, 2023
17 checks passed
@maxpkatz maxpkatz deleted the rm_actual_rhs branch August 9, 2023 22:00
@maxpkatz maxpkatz mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale