Remove unneeded actual_rhs.H from new network scheme #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion back to d/dY form was missing the multiplication by A for the d/dX terms. Also, the J(ash, net_ienuc) term was missing.
…mordial chem EOS (AMReX-Astro#1302) Add the eos_input_rp mode for primordial chem EOS. Also, compute the sound speed and stores it in state.cs if pressure is defined.
This fixes invocations of gamma_law with types other than eos_t.
This adds CUDA coverage for both partition functions and self-consistent NSE.
|
The Castro test is failing on this PR but that's because we have it only looking at the last release. The relevant change has already been incorporated in AMReX-Astro/Castro#2534. |
zingale
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.