Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split configuration into files, clarify paths, add opstack doc, update Blockscout, fix flaky deployment #89

Merged
merged 48 commits into from
Dec 28, 2023
Merged

Split configuration into files, clarify paths, add opstack doc, update Blockscout, fix flaky deployment #89

merged 48 commits into from
Dec 28, 2023

Commits on Dec 24, 2023

  1. move config to own package

    @norswap
    norswap committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    75c54ca View commit details
    Browse the repository at this point in the history

  2. separate out paths configurations from main Config class

    @norswap
    norswap committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    cab2c62 View commit details
    Browse the repository at this point in the history

  3. separate out governance configuration from the Config class

    @norswap
    norswap committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    2e0b4e4 View commit details
    Browse the repository at this point in the history

  4. separate out keys and accounts config from the Config class

    @norswap
    norswap committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    e3593fc View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. separate out devnet L1 config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    efab8a3 View commit details
    Browse the repository at this point in the history

  2. separate out network config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    0d2cd0c View commit details
    Browse the repository at this point in the history

  3. separate out l1 contracts deployment config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    d89485b View commit details
    Browse the repository at this point in the history

  4. separate out explorer config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    a68c803 View commit details
    Browse the repository at this point in the history

  5. separate out L2 engine configuration from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    b54b35c View commit details
    Browse the repository at this point in the history

  6. separate out L2 node config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    57443b0 View commit details
    Browse the repository at this point in the history

  7. move _url functions to network.py

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    88d140a View commit details
    Browse the repository at this point in the history

  8. separate out proposer config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    b210802 View commit details
    Browse the repository at this point in the history

  9. separate out the batcher config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    96472ba View commit details
    Browse the repository at this point in the history

  10. separate out account abstraction config from the Config class

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    a1ca8d7 View commit details
    Browse the repository at this point in the history

  11. remove warning

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    3e7446e View commit details
    Browse the repository at this point in the history

  12. document extra config options defined in other files

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    521b22d View commit details
    Browse the repository at this point in the history

  13. move AA keys to KeysAccountsConfig

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    8bfe6a5 View commit details
    Browse the repository at this point in the history

  14. move Config to own file

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    bcb5c5f View commit details
    Browse the repository at this point in the history

  15. readd init

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    75e28ed View commit details
    Browse the repository at this point in the history

  16. move example configs to their own file

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    50a86eb View commit details
    Browse the repository at this point in the history

  17. future checks

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    6875213 View commit details
    Browse the repository at this point in the history

  18. rename proposer_ config prefix to l2_proposer for consistency

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    33f5ee0 View commit details
    Browse the repository at this point in the history

  19. internalize OPPaths into PathsConfig

    @norswap
    norswap committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    1ade5de View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. add l1_contracts_in_genesis unused option

    @norswap
    norswap committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    a82882d View commit details
    Browse the repository at this point in the history

  2. add OP stack primer

    @norswap
    norswap committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    4dce1f9 View commit details
    Browse the repository at this point in the history

  3. .deploy in paths config

    @norswap
    norswap committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    3a46149 View commit details
    Browse the repository at this point in the history

  4. move top config.py comments to more appropriate locations

    @norswap
    norswap committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    96d0f4a View commit details
    Browse the repository at this point in the history

  5. specify blockscout port

    @norswap
    norswap committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b2ca85d View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. refactor of configuration files and how they are used 

    - make sure every relevant artifact is saved under the deployments/ dir
- do not regenerate the deploy config and redeploy when one already exists
- the deploy config belongs to "l2" and is cleaned there
- always clean files leftover in the OP repo
    @norswap
    norswap committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    399367b View commit details
    Browse the repository at this point in the history

  2. fix missing logs

    @norswap
    norswap committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    e7d468b View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. remove start-l2, l2 with an existing deploy config will do the same

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    fac3f6f View commit details
    Browse the repository at this point in the history

  2. unique batch inbox address even in default case

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    bae82d8 View commit details
    Browse the repository at this point in the history

  3. default chain ids in config.toml.example

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    5155a34 View commit details
    Browse the repository at this point in the history

  4. don't deploy slowly on devnet

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6256483 View commit details
    Browse the repository at this point in the history

  5. delete ABI dir before deploying if it exists

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    84bcd18 View commit details
    Browse the repository at this point in the history

  6. more fun

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    25f9521 View commit details
    Browse the repository at this point in the history

  7. update docs

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    48c7c3d View commit details
    Browse the repository at this point in the history

  8. bump up the RPC waiting time 

    This is necessary for the scenario where we used `deploy_slowly = false` with
prod preset (when redeploying, the devnet always deploys quickly, but to the
temporary geth node). Not sure why, but it took time for the node to be able to
access the info on the L1.
    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    c673947 View commit details
    Browse the repository at this point in the history

  9. update blockscout

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1c97477 View commit details
    Browse the repository at this point in the history

  10. fix temp geth deploy hanging on "waiting for receipts"

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    7f53031 View commit details
    Browse the repository at this point in the history

  11. log l1 command, rename log_run_config to log_command

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d4a0ddc View commit details
    Browse the repository at this point in the history

  12. s/addresses_json_path/addresses_path

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    571263e View commit details
    Browse the repository at this point in the history

  13. s/l1_contracts_deploy.py/l2_deploy.py for consistency

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    23f3b13 View commit details
    Browse the repository at this point in the history

  14. stop auto-naming deployment after preset

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8e2164c View commit details
    Browse the repository at this point in the history

  15. s/rollup.json/rollup-config.json

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d6a0196 View commit details
    Browse the repository at this point in the history

  16. better defaults for deploy_slowly and proposer_allow_non_finailized w… 

    …hen using the devnet
    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    6dd8ef0 View commit details
    Browse the repository at this point in the history

  17. fix "genesis is not traceable"

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    3b56fd7 View commit details
    Browse the repository at this point in the history

  18. remove leftover comment

    @norswap
    norswap committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    607be91 View commit details
    Browse the repository at this point in the history