Split configuration into files, clarify paths, add opstack doc, update Blockscout, fix flaky deployment #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make sure every relevant artifact is saved under the deployments/ dir - do not regenerate the deploy config and redeploy when one already exists - the deploy config belongs to "l2" and is cleaned there - always clean files leftover in the OP repo
This is necessary for the scenario where we used `deploy_slowly = false` with prod preset (when redeploying, the devnet always deploys quickly, but to the temporary geth node). Not sure why, but it took time for the node to be able to access the info on the L1.
norswap
force-pushed
the
ns/split-config
branch
from
bf7faa1
to
933734b
Compare
…hen using the devnet
norswap
force-pushed
the
ns/split-config
branch
from
933734b
to
607be91
Compare
This was referenced Jan 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Configclass now lives in its own package, where different aspects are split off in various superclasses of theConfigclass.Get rid of the
OPPathsclass and internalize it into thePathsConfigsuperclass. Great deal of clarifying what happens inside the OP monorepo.Move all deployment artifacts into the
deploymentsrepo for clarity. We still need to copy or have files generated over there but we move them away as soon as possible in the lifecycle.Add the
docs/opstackfile that give an intro the OP stack data flow + how it is configured and run using the deploy config, the rollup config, ...Update blockscout to latest stable version and document remaining issues
Fix the flaky deployment on the temporary geth
The deployment name is no longer set to the preset name if not specified (always "rollup" by default)
Misc small refactorings and quality of life improvements