Run L1 devnet #12
Run L1 devnet #12
Conversation
norswap
force-pushed
the
ns/exploration
branch
from
9e42ac7
to
c555ea8
Compare
|
99% ready, still want to do one or two cleanups (e.g. want to go back to arrays as parameter to Also, need to rerun the whole thing on a fresh VM to try to shake out a few possible bugs. (I already did this midway, and it caught tons of stuff in the dependency handling, so hopefully not much on the second pass.) |
The previous one used a hardhat-based system that I had trouble getting to run.
norswap
force-pushed
the
ns/exploration
branch
from
c555ea8
to
95c4a9b
Compare
|
|
||
| #################################################################################################### | ||
|
|
||
| class OPPaths: |
There was a problem hiding this comment.
@norswap @ayazabbas @eerkaijun I prefer use a separate dir for our whole deployment structure instead coupled in OP monorepo. I think our tools will focus on deployment so that we just need some files generated for deployment, such as binary, genesis file, key file, config file etc. We can generate directly or move to the specific deployment dir, this step is like a provision process. After that, we can reuse this assets to deploy on various different platform which like our design doc.
There was a problem hiding this comment.
We discussed this on our call: some of these we could move, some of them, there are things we're used in the monorepo (notably Deploy.sol) that assume fixed paths, so we can't change them without patching these files too.
I'd say it's nice to have but not a priority. Let's open an issue about it.
l1.py
Outdated
| patch(paths) | ||
| generate_devnet_l1_genesis(paths) | ||
| start_devnet_l1_node(paths) | ||
| generate_devnet_l1_config(paths) |
There was a problem hiding this comment.
can generate config before start L1 node? I think it should be better if we can do provision work before start the service, it will also benefit when we support different deployment platform besides localhost.
There was a problem hiding this comment.
The "devnet L1 config" is a actually a "devnet" or "network" config and is not used for spinning the L1. I've changed the name to clarify, and changed the order too (but doesn't matter)
cf. #8
Work in progress but getting closer