Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local ruff check does not match up with remote ruff check #16

Closed
norswap opened this issue Aug 18, 2023 · 2 comments · Fixed by #32
Closed

Local ruff check does not match up with remote ruff check #16

norswap opened this issue Aug 18, 2023 · 2 comments · Fixed by #32
Assignees

Comments

@norswap
Copy link
Member

norswap commented Aug 18, 2023

When running the check on #12 (before I fixed it) (transcript):

Successfully installed ruff-0.0.285
libroll.py:55:45: E721 Do not compare types, use `isinstance()`
Found 1 error.
make: *** [Makefile:2: linter] Error 1

Locally I have ruff 0.0.284, which the install.sh script is happy to accept. We should make sure that if the users reruns source scripts/install.sh then the results of ruff matches up to the server (by constraining version in both of these places?).

@GrapeBaBa
Copy link
Contributor

it seems ruff releasing very often. If we always use latest version, we will get lint issues even no code/minor code change. Probably we need focus a version right now? @norswap @ayazabbas @eerkaijun

@norswap
Copy link
Member Author

norswap commented Aug 21, 2023

Yes, let's just settle on the latest version right now, and we'll update it periodically :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants