You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the check on #12 (before I fixed it) (transcript):
Successfully installed ruff-0.0.285
libroll.py:55:45: E721 Do not compare types, use `isinstance()`
Found 1 error.
make: *** [Makefile:2: linter] Error 1
Locally I have ruff 0.0.284, which the install.sh script is happy to accept. We should make sure that if the users reruns source scripts/install.sh then the results of ruff matches up to the server (by constraining version in both of these places?).
The text was updated successfully, but these errors were encountered:
it seems ruff releasing very often. If we always use latest version, we will get lint issues even no code/minor code change. Probably we need focus a version right now? @norswap@ayazabbas@eerkaijun
When running the check on #12 (before I fixed it) (transcript):
Locally I have ruff 0.0.284, which the
install.sh
script is happy to accept. We should make sure that if the users rerunssource scripts/install.sh
then the results ofruff
matches up to the server (by constraining version in both of these places?).The text was updated successfully, but these errors were encountered: