Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fixing and interface update #2

Conversation

vvchernov
Copy link
Collaborator

@vvchernov vvchernov commented Dec 27, 2023

Refactor for octoml#82 PR

  • Rebase to batch-serving
  • Additional update new OpenAI API for logprobs
  • Fix small issues
  • Fix mypy

masahi and others added 17 commits December 19, 2023 19:32
* wip

* wip

* fixed

* fix missing finish reason for EOS and do length check early

* optimize stop sequence handling

* fixed

* use list for stopped seqs

* Return FinishReason.Stop with last non-empty delta

* add a lock around stopped_sequences processing

* remove sequence_map entries after a request is finished

* fix handler
* wip

* bring back assert

* fix overcounted partially shared token counts
* Add sampling penalties and logit bias

This PR adds the sampling penlaties of frequency penalty and presence penalty. Also it adds the logit bias.

* fix

* fix lint

* vectorized sampling

* apply code review suggestions

* fix
This PR fixes the `SamplingParams.logit_bias_index` and `SamplingParams.logit_bias_value` if `SamplingParams.logit_bias` is `None`.
* remove mlc_llm dependency

* use staging engine by default

* wip

* done
This PR fixes the frequency/presence penalty for first token.
add repetition penalty
* Update exception chaining for mlc-serve

* Add more support for using contextvars
* Fix async_connector.py

* Fix

* --amend
Init with tests.
Server working.
Major fix, serve working great.
Minor fix and tests.
Remove extra line.
fix log_softmax
use constant for number of top logprobs
small clean
upstream to new OpenAI API

Co-authored-by: Valery Chernov <[email protected]>
@vvchernov vvchernov force-pushed the vc/update_logprob branch 7 times, most recently from ea7a66c to 901b16e Compare December 29, 2023 07:07
Copy link
Owner

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vvchernov for sending in this patch! LGTM.

@zxybazh zxybazh merged commit 5bb9fd2 into zxybazh:feature/2023-11-22/enable-mlc-server-logprobs Dec 31, 2023
1 check passed
@vvchernov vvchernov deleted the vc/update_logprob branch January 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants