deps: Upgrade video_player_android to 2.7.3 #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: https://pub.dev/packages/video_player_android/changelog This update migrates the plugin to use newer API recommended to support Impeller: https://docs.flutter.dev/release/breaking-changes/android-surface-plugins Without this migration, the videos do play but they look pixelated, resulting in a bad UX. Additionally updates the underlying Media3-ExoPlayer library to version 1.4.1: https://developer.android.com/jetpack/androidx/releases/media3#1.4.1
rajveermalviya
added
the
maintainer review
|
Sure, LGTM, thanks! Marking for Greg's review. |
chrisbobbe
added
integration review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
https://pub.dev/packages/video_player_android/changelog
This update migrates the plugin to use newer API recommended
to support Impeller:
https://docs.flutter.dev/release/breaking-changes/android-surface-plugins
Without this migration, the videos do play but they look
pixelated, resulting in a bad UX.
Additionally, it updates the underlying Media3-ExoPlayer
library to version 1.4.1:
https://developer.android.com/jetpack/androidx/releases/media3#1.4.1