Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add didGeneratePNGData callback prop #39

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

andrewrothman
Copy link

Hi!

I've been using qrcode.react at my employer, and we needed to have a download button to save the generated QR code as an image.

How we're using this PR internally:

<QRCode didGeneratePNGData={qrcodeData => this.setState({ qrcodeData })} />
state = {
    qrcodeData: ""
};

onDownloadClicked() {
    const downloadAnchor = document.createElement("a");
    downloadAnchor.setAttribute("download", "QR.png");
    downloadAnchor.setAttribute("href", this.state.qrcodeData);
    downloadAnchor.click();
}

This has been working perfectly for us for ~6 moths. I just updated it to the newest zpao/master for React 16, and tested it within our project.

Let me know what you think.

Best,
Andrew

@Domino987
Copy link

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants