Add free text annotation font size update when resizing #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvasilak
force-pushed
the
fix-free-text-annotation-resize
branch
from
6608705
to
89cd129
Compare
michalrentka
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user resizes a free text annotation, potential font size change is not communicated in the notification received by PSPDFKit (using
notification.userInfo?[PSPDFAnnotationChangedNotificationKeyPathKey]), and therefore is not synced. UpdatingfontSizewhenever a free text annotation has aboundingBoxchange, even if font size didn't change, fixes this on our side.I'll also report this to PSPDFKit, as it seems an omission on their side.