Improve keyboard visible height calculation (#1012)

zotero · Sep 19, 2024 · 645116b · 645116b
1 parent fdb3fe9
commit 645116b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Zotero/Models/KeyboardData.swift b/Zotero/Models/KeyboardData.swift
@@ -15,7 +15,10 @@ struct KeyboardData {
     let animationOptions: UIView.AnimationOptions
 
     var visibleHeight: CGFloat {
-        return UIScreen.main.bounds.height - self.endFrame.minY
+        // endFrame.height might be 0 for a floating keyboard that is hiding, so return 0 for this case.
+        // Additionally, floating keyboard will not reach the end of the screen, therefore we can ignore it.
+        guard endFrame.height > 0, endFrame.maxY >= UIScreen.main.bounds.height else { return 0 }
+        return UIScreen.main.bounds.height - endFrame.minY
     }
 
     init?(userInfo: [AnyHashable: Any]) {