Try to align golang around a single version #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have version defined in: go.mod/go.sum (1.12) .github actions (1.18) Dockerfile (1.20) This PR tries to align them to the latest version, which is the Dockerfile, this should help with some of the library updates by dependabot, as at least one of them (prometheus) fails due to requiring golang 1.20
We don't seem to actually use this somewhere, but build in support for aligning similarly
|
Note that a LOT of extra versions of libraries seem to be dropped. These appear to largely be dropped if we "only" align to the github pipelines version of 1.18, which also happens to resolve a number of CVEs my company's code scanner is picking up like: |
phillip-stephens
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have version defined in:
go.mod/go.sum (1.12)
.github actions (1.18)
Dockerfile (1.20)
This PR tries to align them to the latest version, which is the Dockerfile, this should help with some of the library updates by dependabot, as at least one of them (prometheus) fails due to requiring golang 1.20
I try to have github actions read the golang version, to reduce maintenance
I updated go.mod to update 1.12 to 1.20, and then ran
go mod tidywhich added everything else.Add a description of your changes here.
How to Test
Add brief instructions on how to test your changes.
Notes & Caveats
If necessary, explain the motivation for this PR, and note any caveats that apply to your changes or future work that will be needed.
Issue Tracking
Add a link to the relevant GitHub issue(s) if the pull request resolves it.