Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphical): fix nested error wrapping #358

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Conversation

TheLostLambda
Copy link
Contributor

@TheLostLambda TheLostLambda commented Mar 27, 2024

Fixes #333

Here is an error now nicely wrapping (with the 2 char padding on either side) of a 50-char wide terminal:
image

@TheLostLambda
Copy link
Contributor Author

There is a second error here too that's come up! The prefixes for #[related] errors are messing up the line-width calculations:
image

The easiest solution seems to be changing the header to always add a newline after one of these tags — something that I think looks nicer anyways!
image

I'll also include that change in this PR!

@TheLostLambda
Copy link
Contributor Author

I've also fixed the spacing around / between related errors, and I'm trying to fix up some unrelated CI breakage (the new nightly compiler seems to be much better at / to much more aggressively detect dead code!)

@TheLostLambda TheLostLambda marked this pull request as ready for review March 27, 2024 02:05
@TheLostLambda
Copy link
Contributor Author

Oof, lots of little things making that slightly tricky, but ready for review now! I tried to keep some nice and meaningful commits if you're the type of person to review those diffs one-at-a-time!

@TheLostLambda
Copy link
Contributor Author

Finally, if you're looking for more example outputs and how they have changed / been restyled, here are plenty more examples: TheLostLambda/pgfinder-next@23a4093

@zkat
Copy link
Owner

zkat commented Mar 27, 2024

Thanks for taking care of this! this looks a lot better :)

@zkat zkat merged commit 3eabbce into zkat:main Mar 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially broken word wrapping on main
2 participants