Skip to content

Commit

Permalink
remove _hash outputs
Browse files Browse the repository at this point in the history
  • Loading branch information
PythonFZ committed Jul 27, 2023
1 parent f98d704 commit 2f3d6d7
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion ipsuite/configuration_comparison/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ class ConfigurationComparison(base.IPSNode):
Attributes
----------
hash used to use this Node as zn.Nodes()
reference: typing.Union[utils.helpers.UNION_ATOMS_OR_ATOMS_LST,
utils.types.SupportsAtoms]
reference configurations to compare analyte to
Expand Down
3 changes: 0 additions & 3 deletions ipsuite/configuration_selection/base.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Base Node for ConfigurationSelection."""
import logging
import typing
import uuid

import ase
import znflow
Expand All @@ -27,7 +26,6 @@ class ConfigurationSelection(base.ProcessAtoms):
"""

_hash = zntrack.zn.outs()
exclude_configurations: typing.Union[
typing.Dict[str, typing.List[int]], base.protocol.HasSelectedConfigurations
] = zntrack.zn.deps(None)
Expand All @@ -47,7 +45,6 @@ def _post_init_(self):

def run(self):
"""ZnTrack Node Run method."""
self._hash = str(uuid.uuid4())
if self.exclude is not None:
if self.exclude_configurations is None:
self.exclude_configurations = {}
Expand Down
4 changes: 1 addition & 3 deletions ipsuite/data_loading/add_data_h5md.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Load Data directly from a H5MD trajectory file."""
import functools
import typing
import uuid

import ase
import h5py
Expand All @@ -15,11 +14,10 @@ class AddDataH5MD(base.IPSNode):
"""Load Data directly from a H5MD trajectory file."""

file = zntrack.dvc.deps()
_hash = zntrack.zn.outs()
_atoms = None

def run(self):
self._hash = str(uuid.uuid4()) # we must have an output
pass

@property
def atoms(self) -> typing.List[ase.Atoms]:
Expand Down

0 comments on commit 2f3d6d7

Please sign in to comment.