Build distributions in an isolated environment. #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise `build` cannot install packages needed for the build system, for example `hatchling`. Fixes issue #448.
Instead of `tha.example-0.1.tar.gz` you get `tha_example-0.1.tar.gz`. Wheels currently still have dots there, but those might become underscores at some point as well. This is actually a problem for Buildout: buildout/buildout#647 The change in this PR does have a bit of an effect: - Previously when we were running `build`, it would run in non-isolated mode. So if you make sure you have an older `setuptools` version in the venv of `zest.releaser`, you get dots, like was always the case. - Now with this PR, we run in isolated mode, which means that `build` will most likely install the latest setuptools version. Well, it does that if setuptools is the chosen build-system, and I think this is still the default, at least if there is a `setup.py`. You can influence this in the `pyproject.toml` of the package you are releasing. In Plone we have this in most packages: ``` [build-system] requires = ["setuptools>=68.2"] ``` I think we want it like this now: ``` [build-system] requires = ["setuptools>=68.2,<=69.2"] ``` I am mostly writing this as note to myself. :-)
|
I found out what was going wrong in the tests. This actually has nothing to do with the changes in this PR. The scheduled tests already fail. It took a long time before I saw what the actual diff was. Wwith Okay, I have updated the tests. See commit 934ffb7 for more details. |
reinout
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise
buildcannot install packages needed for the build system, for examplehatchling. Fixes issue #448.I see a few test failures locally, which should only be small differences in the output during release. Let's see if they are there on GitHub as well.
Code is taken from how
builddoes it itself.