Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error output when calling build. #427

Merged
merged 2 commits into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ Changelog for zest.releaser
9.0.0a2 (unreleased)
--------------------

- Ignore error output when calling `build`.
We only need to look at the exit code to see if it worked.
mauritsvanrees marked this conversation as resolved.
Show resolved Hide resolved
You can call zest.releaser with ``--verbose`` if you want
to see the possible warnings.

- Removed ``encoding`` config option as nobody is using it anymore (using the
option would result in a crash). Apparently it isn't needed anymore now that
we don't use python 2 anymore. Fixes `issue 391
Expand Down
2 changes: 1 addition & 1 deletion zest/releaser/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ def _execute_command(command, cwd=None, extra_environ=None):
show_stderr = False
# But we really DO want to see the stderr for some other Python commands,
# otherwise for example a failed upload would not even show up in the output.
for flag in ("upload", "register", "build_sdist", "build_wheel", "-mbuild"):
for flag in ("upload", "register"):
if flag in command:
show_stderr = True
break
Expand Down
Loading