Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded (and crashing) encoding config option #425

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Remove unneeded (and crashing) encoding config option #425

merged 2 commits into from
Jul 13, 2023

Conversation

reinout
Copy link
Collaborator

@reinout reinout commented Jul 13, 2023

No description provided.

@reinout
Copy link
Collaborator Author

reinout commented Jul 13, 2023

Better fix than #424

@reinout reinout mentioned this pull request Jul 13, 2023
Closed
mauritsvanrees
mauritsvanrees approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I did not find any package on my system that uses this option. I think I might have in the past, or that I had problems in at least one package, that I maybe simply fixed by changing non-ascii to ascii.

@mauritsvanrees mauritsvanrees merged commit cf11733 into master Jul 13, 2023
6 checks passed
@mauritsvanrees mauritsvanrees deleted the reinout-encoding-gone branch July 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinout @mauritsvanrees