net: ipv6: Make Multicast Listener Discovery API public #79274
+95
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Samples
zephyrbot
requested review from
jukkar,
kartben,
nashif,
pdgendt,
ssharks and
tbursztyka
pdgendt
previously approved these changes
Oct 1, 2024
LuDuda
approved these changes
Oct 1, 2024
jukkar
previously approved these changes
Oct 2, 2024
kartben
reviewed
Oct 3, 2024
include/zephyr/net/mld.h
Outdated
| * @param iface Network interface where join message is sent | ||
| * @param addr Multicast group to join | ||
| * | ||
| * @return Return 0 if joining was done, <0 otherwise. |
There was a problem hiding this comment.
Suggested change
| * @return Return 0 if joining was done, <0 otherwise. | |
| * @return 0 if joining was done, <0 otherwise. |
include/zephyr/net/mld.h
Outdated
| * @param iface Network interface where leave message is sent | ||
| * @param addr Multicast group to leave | ||
| * | ||
| * @return Return 0 if leaving is done, <0 otherwise. |
There was a problem hiding this comment.
Suggested change
| * @return Return 0 if leaving is done, <0 otherwise. | |
| * @return 0 if leaving is done, <0 otherwise. |
| /** | ||
| * @brief MLD (Multicast Listener Discovery) | ||
| * @defgroup mld Multicast Listener Discovery API | ||
| * @since 1.8 |
There was a problem hiding this comment.
I understand the API existed before as internal but it seems odd to state 1.8 here since strictly speaking it's being introduced only now as public API?
There was a problem hiding this comment.
The API could have been called earlier too by the application even if it was internal, so I think it is ok to have the version set when the API was created.
rlubos
force-pushed
the
net/make-ipv6-mld-api-public
branch
from
1b5f70c
to
29c2aa7
Compare
pdgendt
previously approved these changes
Oct 4, 2024
kartben
previously approved these changes
Oct 4, 2024
IPv6 MLD API was so far defined in an internal header. This does not seem correct though, as application code should be able to join/leave multicast groups, hence the API should be exposed in a public header, just as it is done for its IPv4 countepart - IGMP. Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
net/make-ipv6-mld-api-public
branch
from
29c2aa7
to
0f970a8
Compare
|
Rebased & resolved conflict |
pdgendt
approved these changes
Oct 4, 2024
jukkar
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 MLD API was so far defined in an internal header. This does not seem correct though, as application code should be able to join/leave multicast groups, hence the API should be exposed in a public header, just as it is done for its IPv4 countepart - IGMP.