-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: nordic: nrf7002dk: re-enable external flash by default #79191
Open
bjarki-andreasen
wants to merge
1
commit into
zephyrproject-rtos:main
Choose a base branch
from
bjarki-andreasen:nrf7002dk-enable-ext-flash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
boards: nordic: nrf7002dk: re-enable external flash by default #79191
bjarki-andreasen
wants to merge
1
commit into
zephyrproject-rtos:main
from
bjarki-andreasen:nrf7002dk-enable-ext-flash
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
added
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
size: XS
A PR changing only a single line of code
labels
Sep 30, 2024
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
September 30, 2024 09:51
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
nordicjm
approved these changes
Sep 30, 2024
anangl
approved these changes
Sep 30, 2024
LuDuda
approved these changes
Sep 30, 2024
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 1, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 4, 2024
… default The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Upstream PR: zephyrproject-rtos/zephyr#79191 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi. This commit removes the status = "disabled"; Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
nrf7002dk-enable-ext-flash
branch
from
October 4, 2024 13:42
6fc3e34
to
16af595
Compare
Rebased, some strange CI warning regarding wifi driver, hopefully rebase makes them go away :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: nRF
Nordic nRFx
size: XS
A PR changing only a single line of code
Trivial
Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external flash (mx25r64) was accidentally disabled during testing. The node should be enabled by default like its spi.
This commit removes the
status = "disabled";