-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: audio: dmic_nrfx_pdm: Add multi-instance PDM and support for prescaler #79177
Open
mstasiaknordic
wants to merge
5
commits into
zephyrproject-rtos:main
Choose a base branch
from
mstasiaknordic:pdm_driver_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
drivers: audio: dmic_nrfx_pdm: Add multi-instance PDM and support for prescaler #79177
mstasiaknordic
wants to merge
5
commits into
zephyrproject-rtos:main
from
mstasiaknordic:pdm_driver_update
+3,461
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
hubertmis,
jaz1-nordic,
kartben,
kl-cruz,
krish2718,
kv2019i,
lgirdwood,
lyakh,
magp-nordic,
masz-nordic,
nashif,
nika-nordic and
nordic-krch
September 30, 2024 07:35
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
This PR should not be merged (Do Not Merge)
labels
Sep 30, 2024
mstasiaknordic
force-pushed
the
pdm_driver_update
branch
from
September 30, 2024 09:27
b2d7a33
to
1537dee
Compare
nika-nordic
reviewed
Sep 30, 2024
mstasiaknordic
force-pushed
the
pdm_driver_update
branch
3 times, most recently
from
September 30, 2024 11:10
f21b575
to
4401c1a
Compare
gmarull
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAL update happening here: #78631
mstasiaknordic
force-pushed
the
pdm_driver_update
branch
from
October 2, 2024 08:49
4401c1a
to
2e9f621
Compare
mstasiaknordic
force-pushed
the
pdm_driver_update
branch
from
October 2, 2024 09:06
2e9f621
to
3d4b47a
Compare
Added dedicated nrfx configuration files for nRF54L15 FP1, which differ from ENGA variant with inclusion of PDM. Updated NRFX version to 3.7 in configuratuon files to enable the use of new API. Signed-off-by: Michał Stasiak <[email protected]>
New PDM, some present on nRF54L15 FP1, instances have been added. Modified condfiguration file for nRF5340, which now requires PDM0 instance. Signed-off-by: Michał Stasiak <[email protected]>
Driver now uses multi-instance PDM nrfx API and defines PDM device based on available instances. It also introduces calculating PDM frequency using prescaler, present on nRF54L15 FP1. Signed-off-by: Michał Stasiak <[email protected]>
nRF54L15 FP1 can now be used in dmic audio sample. Signed-off-by: Michał Stasiak <[email protected]>
Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
force-pushed
the
pdm_driver_update
branch
from
October 3, 2024 06:25
3d4b47a
to
b0ce5d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Audio
area: Samples
Samples
DNM
This PR should not be merged (Do Not Merge)
manifest
manifest-hal_nordic
platform: nRF
Nordic nRFx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New nRF targets include multiple instances of PDM peripheral. Thus, both nrfx and Zephyr drivers had to be adjusted to support it. Moreover, enumerated PDM frequency is replaced by prescaler value, which is used in functions responsible for finding suitable clock.
This PR also adds missing nrfx_config files for nRF54L15dk, which used pdk files. The only difference is inclusion of PDM20 and PDM21.
Added support for nRF54L15dk in audio dmic sample.
This PR can be merged after one updating nrfx to 3.7 - #78631