cmake: mcuboot: Use imgtool instead of west for signing #78983
+180
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
Release Notes
zephyrbot
requested review from
57300,
carlescufi,
d3zd3z,
dkalowsk,
jeremybettis,
kartben,
mbolivar-ampere,
mmahadevan108,
nashif,
pdgendt and
swinslow
pdgendt
reviewed
Sep 25, 2024
nordicjm
force-pushed
the
mcubootsingingimgtool
branch
from
82d79f4
to
d3d3c9e
Compare
pdgendt
previously approved these changes
Sep 25, 2024
|
cc @butok |
|
The Zephyr "west sign" documentation should be updated https://docs.zephyrproject.org/latest/develop/west/sign.html |
nordicjm
force-pushed
the
mcubootsingingimgtool
branch
from
d3d3c9e
to
3c5a83a
Compare
Updated |
pdgendt
previously approved these changes
Sep 26, 2024
butok
previously approved these changes
Sep 26, 2024
mmahadevan108
previously approved these changes
Sep 26, 2024
|
@tejlmand , kindly review. |
de-nordic
previously approved these changes
Sep 26, 2024
tejlmand
requested changes
Oct 3, 2024
Adds a Kconfig which can be selected when building for firmware updater mode to select if this is the application or the firmware updater image that is being built Signed-off-by: Jamie McCrae <[email protected]>
Uses imgtool directly to sign images instead of calling west sign, this also removes the MCUBOOT_CMAKE_WEST_SIGN_PARAMS Kconfig option as this has no effect Signed-off-by: Jamie McCrae <[email protected]>
Removes the Kconfig extension function around a Kconfig that has been removed Signed-off-by: Jamie McCrae <[email protected]>
Fixes a compliance error Signed-off-by: Jamie McCrae <[email protected]>
Deprecates signing for imgtool using west sign Signed-off-by: Jamie McCrae <[email protected]>
Adds a note that the build system now uses imgtool directly Signed-off-by: Jamie McCrae <[email protected]>
Adds details on the deprecation of this feature Signed-off-by: Jamie McCrae <[email protected]>
Adds a signing page under build, which contains information on how to sign images from the build system, this removes the old details for using west sign with imgtool from the west sign page Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
dismissed stale reviews from de-nordic, mmahadevan108, butok, and pdgendt
via
6e43321
nordicjm
force-pushed
the
mcubootsingingimgtool
branch
from
3c5a83a
to
6e43321
Compare
tejlmand
approved these changes
Oct 4, 2024
|
|
||
| # If single slot mode, or if in firmware updater mode and this is the firmware updater image, | ||
| # use slot 0 information | ||
| if(NOT CONFIG_MCUBOOT_BOOTLOADER_MODE_SINGLE_APP AND (NOT CONFIG_MCUBOOT_BOOTLOADER_MODE_FIRMWARE_UPDATER OR CONFIG_MCUBOOT_APPLICATION_FIRMWARE_UPDATER)) |
There was a problem hiding this comment.
minor nit, quite a long line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78044