-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twister: rework board enumeration #77250
base: main
Are you sure you want to change the base?
Conversation
5e1b8b1
to
eb5060d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I like where this is going with one twister.yaml
file per board directory, allowing to special-case the various variants of a board. This should also clear up some of the confusion as to what the board YAML (now: twister.yaml
) file is used for.
boards/arm/fvp_base_revc_2xaemv8a/fvp_base_revc_2xaemv8a_fvp_base_revc_2xaemv8a_smp_ns.yaml
Show resolved
Hide resolved
7a31de9
to
f4aa094
Compare
fd66817
to
759726a
Compare
adapted all tests and fixed many issues discovered by the twister testsuite... |
@gchwier @golowanow @PerMac @LukaszMrugala @hakehuang please review. it is still in early draft with many cleanups to be done, but the basic functionality is working. |
759726a
to
31aee86
Compare
can we have a yaml processing script that can auto merge yaml files that are impacted to twister.yaml? |
31aee86
to
39b15de
Compare
we can, for majority of boards this will not be needed as it means a simple rename only though. |
39b15de
to
5c4a596
Compare
5c4a596
to
ee59730
Compare
ee59730
to
04ce675
Compare
We now use hwmv2 to list boards instead of relying on twister specific config files. One yaml files (twister.yaml for now) will have all the data needed for all possible targets and variations of a board reusing most of the data where possible and variations can override the top level data. Twister keeps track of 'aliases' of boards and identifies that for example native_sim is the same as native_sim/native, so either names will be possible in both test yaml files or on the command line, however, the reporting will always use the full name, so no there is no confusion about what is being tested/built. Signed-off-by: Anas Nashif <[email protected]>
Use twister.yaml and fix revisions in board.yml. Signed-off-by: Anas Nashif <[email protected]>
Use one single twister configuration file. Signed-off-by: Anas Nashif <[email protected]>
Updated tests for new board handling. Signed-off-by: Anas Nashif <[email protected]>
configure revisions in board.yml file. Signed-off-by: Anas Nashif <[email protected]>
Do not use shortcuts... Signed-off-by: Anas Nashif <[email protected]>
no shortcuts allowed in test files Signed-off-by: Anas Nashif <[email protected]>
04ce675
to
ae303ae
Compare
Full name or description of a board is something we are missing in HWVv2. It is right now being added to yaml files parsed by twister. This should be generically available to tooling and documentation independently from twister. As we rework how twister parses board meta-data (zephyrproject-rtos#77250) and how we generate board documentation (zephyrproject-rtos#79160), this becomes neceassry. Moving the board full name/description from the twister yaml files to the board.yaml is something we can automate once the schema is agreed upon. Signed-off-by: Anas Nashif <[email protected]>
Full name or description of a board is something we are missing in HWVv2. It is right now being added to yaml files parsed by twister. This should be generically available to tooling and documentation independently from twister. As we rework how twister parses board meta-data (zephyrproject-rtos#77250) and how we generate board documentation (zephyrproject-rtos#79160), this becomes neceassry. Moving the board full name/description from the twister yaml files to the board.yaml is something we can automate once the schema is agreed upon. Signed-off-by: Anas Nashif <[email protected]>
We now use hwmv2 to list boards instead of relying on twister specific
config files.
One yaml file (twister.yaml for now) will have all the data needed for
all possible targets and variations of a board reusing most of the data
where possible and variations can override the top level data.
Twister keeps track of 'aliases' of boards and identifies that for
example native_sim is the same as native_sim/native, so either names
will be possible in both test yaml files or on the command line,
however, the reporting will always use the full name, so no there is no
confusion about what is being tested/built.
Fixes #74142