Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twister: rework board enumeration #77250

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nashif
Copy link
Member

@nashif nashif commented Aug 19, 2024

We now use hwmv2 to list boards instead of relying on twister specific
config files.

One yaml file (twister.yaml for now) will have all the data needed for
all possible targets and variations of a board reusing most of the data
where possible and variations can override the top level data.

Twister keeps track of 'aliases' of boards and identifies that for
example native_sim is the same as native_sim/native, so either names
will be possible in both test yaml files or on the command line,
however, the reporting will always use the full name, so no there is no
confusion about what is being tested/built.

  • twister: rework board handling
  • boards: other: stm32_min_dev: use one twister.yaml
  • boards: intel_adsp: use one twister.yaml

Fixes #74142

@nashif nashif force-pushed the topic/twister/board_def_3 branch 2 times, most recently from 5e1b8b1 to eb5060d Compare August 20, 2024 11:12
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I like where this is going with one twister.yaml file per board directory, allowing to special-case the various variants of a board. This should also clear up some of the confusion as to what the board YAML (now: twister.yaml) file is used for.

@nashif nashif force-pushed the topic/twister/board_def_3 branch 2 times, most recently from 7a31de9 to f4aa094 Compare August 22, 2024 13:44
@nashif nashif force-pushed the topic/twister/board_def_3 branch 2 times, most recently from fd66817 to 759726a Compare September 19, 2024 15:00
@nashif
Copy link
Member Author

nashif commented Sep 19, 2024

adapted all tests and fixed many issues discovered by the twister testsuite...

@nashif
Copy link
Member Author

nashif commented Sep 19, 2024

@gchwier @golowanow @PerMac @LukaszMrugala @hakehuang please review. it is still in early draft with many cleanups to be done, but the basic functionality is working.

@hakehuang
Copy link
Collaborator

can we have a yaml processing script that can auto merge yaml files that are impacted to twister.yaml?

@nashif
Copy link
Member Author

nashif commented Sep 25, 2024

can we have a yaml processing script that can auto merge yaml files that are impacted to twister.yaml?

we can, for majority of boards this will not be needed as it means a simple rename only though.

@nashif nashif marked this pull request as ready for review September 25, 2024 23:10
@zephyrbot zephyrbot added area: ARM64 ARM (64-bit) Architecture area: Zbus platform: ARM Arm Limited platform: Intel ADSP Intel Audio platforms area: Twister Twister labels Sep 25, 2024
We now use hwmv2 to list boards instead of relying on twister specific
config files.
One yaml files (twister.yaml for now) will have all the data needed for
all possible targets and variations of a board reusing most of the data
where possible and variations can override the top level data.

Twister keeps track of 'aliases' of boards and identifies that for
example native_sim is the same as native_sim/native, so either names
will be possible in both test yaml files or on the command line,
however, the reporting will always use the full name, so no there is no
confusion about what is being tested/built.

Signed-off-by: Anas Nashif <[email protected]>
Use twister.yaml  and fix revisions in board.yml.

Signed-off-by: Anas Nashif <[email protected]>
Use one single twister configuration file.

Signed-off-by: Anas Nashif <[email protected]>
Updated tests for new board handling.

Signed-off-by: Anas Nashif <[email protected]>
configure revisions in board.yml file.

Signed-off-by: Anas Nashif <[email protected]>
Do not use shortcuts...

Signed-off-by: Anas Nashif <[email protected]>
no shortcuts allowed in test files

Signed-off-by: Anas Nashif <[email protected]>
nashif added a commit to nashif/zephyr that referenced this pull request Oct 4, 2024
Full name or description of a board is something we are missing in
HWVv2. It is right now being added to yaml files parsed by twister. This
should be generically available to tooling and documentation
independently from twister.

As we rework how twister parses board meta-data (zephyrproject-rtos#77250) and how we
generate board documentation (zephyrproject-rtos#79160), this becomes neceassry.

Moving the board full name/description from the twister yaml files to
the board.yaml is something we can automate once the schema is agreed
upon.

Signed-off-by: Anas Nashif <[email protected]>
nashif added a commit to nashif/zephyr that referenced this pull request Oct 4, 2024
Full name or description of a board is something we are missing in
HWVv2. It is right now being added to yaml files parsed by twister. This
should be generically available to tooling and documentation
independently from twister.

As we rework how twister parses board meta-data (zephyrproject-rtos#77250) and how we
generate board documentation (zephyrproject-rtos#79160), this becomes neceassry.

Moving the board full name/description from the twister yaml files to
the board.yaml is something we can automate once the schema is agreed
upon.

Signed-off-by: Anas Nashif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twister does not understand HWMv2 board qualifiers for platform arguments
6 participants