Bluetooth: CCP: Introduce new CCP API #77120
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
ccp_register
branch
3 times, most recently
from
6aa67a6
to
63398a4
Compare
Thalley
force-pushed
the
ccp_register
branch
6 times, most recently
from
4599b32
to
fc5da98
Compare
Thalley
commented
Aug 28, 2024
Comment on lines
+66
to
+71
| int bt_ccp_server_register_bearer(const struct bt_tbs_register_param *param, | ||
| struct bt_ccp_server_bearer **bearer); |
There was a problem hiding this comment.
For reviewers: I consider the following naming options:
- bt_ccp_ccs (Bluetooth Call Control Profile Call Control Server, where Call Control Server is the actual name of the role in CCP)
- bt_ccp_call_control_server (more verbose version of the above; naming similar to e.g. bt_bap_unicast_server)
- bt_ccp_call_ctrl_srv (shorter version of 3, more similar to the VCP and MICP APIs (e.g. bt_vcp_vol_rend)
- bt_ccp_server (and in upcoming PRs, bt_ccp_client).
If you have any preferences or other suggestions, please let me know and we can just do a rename
Thalley
force-pushed
the
ccp_register
branch
4 times, most recently
from
87437d8
to
1e8dcd7
Compare
Thalley
force-pushed
the
ccp_register
branch
6 times, most recently
from
87a92cf
to
3c73258
Compare
Thalley
force-pushed
the
ccp_register
branch
9 times, most recently
from
0ede37d
to
c3c5f3f
Compare
alloc_value is more correct as it does allocate a new value, rather than just returning/getting a value. Signed-off-by: Emil Gydesen <[email protected]>
Rather than throwing an assert, it will now do a better check for already-allocated CCIDs and return an error instead. Signed-off-by: Emil Gydesen <[email protected]>
Move the CCID header to the include directory to make it public. This also compiles the ccid.c file whenver CONFIG_BT_AUDIO is enabled, rather than having an additional Kconfig for it, since the API is now public and may be used by other than our internal services. Signed-off-by: Emil Gydesen <[email protected]>
Add unit tests of the CCID functions. To support these new tests, the GATT mocks need to support dynamic GATT DB so we can add and remove a service that contains CCIDs. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
ccp_register
branch
3 times, most recently
from
6e4cbd3
to
d7d0cb2
Compare
The CCP API for the Call Control Profile works on top of the TBS API, and will eventually replace parts of the TBS API. Signed-off-by: Emil Gydesen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCP API for the Call Control Profile works on top of the
TBS API, and will eventually replace parts of the TBS API.
Signed-off-by: Emil Gydesen [email protected]