-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Deprecate adv auto-resume #73395
base: main
Are you sure you want to change the base?
Bluetooth: Deprecate adv auto-resume #73395
Conversation
7d1b3e0
to
68ea33a
Compare
Last push fixes compliance check:
|
Latest push removes the adv/resume2 test, which was failing this PR because of the deprecation warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bluetooth WG meeting:
- Agreement to dreprecate
BT_LE_ADV_OPT_CONNECTABLE
andBT_LE_ADV_OPT_ONE_TIME
and introduce a newBT_LE_ADV_OPT_CONN
which combines the two deprecated options into a single one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an entry in the migration guide
9bb9ed8
to
bc2aa3a
Compare
2f8795b
to
1bfdbfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - Looking forward to getting this feature removed completely
Added the DNM flag for now, until we have a consensus on how to proceed with #77775 since that may have an impact on this API. |
@jhedberg isn't it kind of moot if the API in question is being removed? We are determined to remove auto-resume. |
You're probably right. I just wanted to pull the handbrake a little, in case it would have emerged from the discussion in the other PR that we actually don't want to deprecate/remove this feature. |
c9c11e7
3b06937
to
c9c11e7
Compare
Pushed rebase. No conflicts. |
efd8422
efd8422
to
846f1f6
Compare
846f1f6
to
a8428a1
Compare
28337fd
to
1fa9f59
Compare
The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details. This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like `conn_cb.recycled`, which has obvious behavior that is unlikely to change. Resolves: zephyrproject-rtos#72567 Signed-off-by: Aleksander Wasaznik <[email protected]>
1fa9f59
to
8c31990
Compare
The host-based adv auto-resume function has both a problematic implementation and disagreement in the community around how it should behave. See the issue linked resolved below for details.
This patch makes the deprecation visible to the user. The user will be better served by a auto-resume tailored their applications use case, based on more primitive host API like
conn_cb.recycled
, which has obvious behavior that is unlikely to change.Resolves: #72567