ipc: Call ipm_set_enabled() also for dual IPM support #37931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocaione
requested review from
carlescufi,
hubertmis,
KAGA164,
nika-nordic and
doki-nordic
hubertmis
approved these changes
Aug 25, 2021
|
tagging @maje-emb as well |
doki-nordic
approved these changes
Aug 25, 2021
hubertmis
requested changes
Aug 25, 2021
|
After first testing: it seems that the ipc_service and rpmsg_multi_instance samples also stopped working. Tested on nRF5340. |
|
Fix is on the way: carlocaione#1 |
|
@hubertmis @maje-emb uhm, on a second thought I'm not convinced anymore that is the correct fix. The API documentation says indeed that |
The IPC drivers rpmsg_service and rpmsg_multi_instance are not explicitly enabling the RX IPM channel when two different devices are used for TX and RX. While this could be redundant for some IPM drivers, in some cases the hardware needs to be enabled before using it. Add the missing calls to ipm_set_enabled() for both the devices. Signed-off-by: Carlo Caione <[email protected]>
carlocaione
force-pushed
the
add_ipm_set_enabled
branch
from
e1068c8
to
54f9247
Compare
hubertmis
approved these changes
Aug 25, 2021
|
ipc_service and rpmsg_multi_instance samples also work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPC drivers rpmsg_service and rpmsg_multi_instance are not
explicitly enabling the IPM channels when two different devices are used
for TX and RX. While this could be redundant for some IPM drivers, in
some cases the hardware needs to be enabled before using it.
Add the missing calls to ipm_set_enabled() for both the devices.
Signed-off-by: Carlo Caione [email protected]