Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2321 - Fix private callback visibility #2325

Draft
wants to merge 14 commits into
base: development
Choose a base branch
from

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Nov 12, 2021

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@Jeckerson Jeckerson changed the title #2321 - Fox private callback visibility #2321 - Fшx private callback visibility Nov 12, 2021
@Jeckerson Jeckerson changed the title #2321 - Fшx private callback visibility #2321 - Fix private callback visibility Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #2325 (a5a6b18) into development (fd6e5f1) will decrease coverage by 0.04%.
The diff coverage is 18.42%.

@@               Coverage Diff                @@
##             development   #2325      +/-   ##
================================================
- Coverage           7.18%   7.13%   -0.05%     
+ Complexity          8639    8612      -27     
================================================
  Files                343     344       +1     
  Lines              21977   21939      -38     
================================================
- Hits                1578    1566      -12     
+ Misses             20399   20373      -26     

@Jeckerson Jeckerson added the bug label Nov 13, 2021
@Jeckerson Jeckerson self-assigned this Nov 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

# Conflicts:
#	Library/CompilerFile.php
#	composer.lock
#	config/autoload.php
#	phpunit.xml.dist
#	tests/ext-bootstrap.php
#	zephir
@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant