Avoid loading config files when executing the liveness probe check #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestie
force-pushed
the
liveness-probe-avoids-loading-config-files
branch
from
15ccad4
to
9656d53
Compare
bestie
force-pushed
the
liveness-probe-avoids-loading-config-files
branch
from
9656d53
to
fc5d2ef
Compare
deepredsky
approved these changes
Apr 11, 2024
It's possible, even common to end up Rails specific logic Racecar config files. `Racecar.config.logger = Rails.logger` for example. In these cases it's not desirable for the liveness probe to use the same configuration mechanism. A new option, `RACECAR_LIVENESS_PROBE_SKIP_CONFIG_FILES` ensures this doesn't happen. Use a new configuration value to avoid confusion
bestie
force-pushed
the
liveness-probe-avoids-loading-config-files
branch
from
fc5d2ef
to
25d02ca
Compare
|
@deepredsky I've changed approach on this a little, updated the readme and added to the changelog. |
deepredsky
approved these changes
Apr 15, 2024
angelim
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a new configuration option that prevents the liveness probe command from loading config files.
Why?
It's possible, even common to end up Rails specific logic Racecar config files.
Racecar.config.logger = Rails.loggerfor example.In these cases it's not desirable for the liveness probe to use the same configuration mechanism. A new option,
RACECAR_LIVENESS_PROBE_SKIP_CONFIG_FILESensures this doesn't happen.