Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Increase demo test timeout to 5s #435

Merged
merged 1 commit into from
Jun 19, 2024
Merged

CI: Increase demo test timeout to 5s #435

merged 1 commit into from
Jun 19, 2024

Conversation

shakeelmohamed
Copy link
Member

@shakeelmohamed shakeelmohamed commented Jun 19, 2024

Summary by Sourcery

This pull request increases the timeout for demo tests from 4 seconds to 5 seconds to ensure tests have sufficient time to complete.

  • CI:
    • Increased the demo test timeout from 4 seconds to 5 seconds to accommodate longer-running tests.

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-audio-player-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 7:34am

Copy link
Contributor

sourcery-ai bot commented Jun 19, 2024

Reviewer's Guide by Sourcery

This pull request increases the test timeout in the demo test file from 4000ms to 5000ms. This change is implemented by modifying the TEST_TIMEOUT constant in the test/demo.js file to provide more time for the tests to complete.

File-Level Changes

Files Changes
test/demo.js Increased the test timeout to ensure tests have sufficient time to complete.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shakeelmohamed - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@shakeelmohamed shakeelmohamed merged commit c0a99c3 into main Jun 19, 2024
6 checks passed
@shakeelmohamed shakeelmohamed deleted the fix-ci branch June 19, 2024 07:39
@shakeelmohamed
Copy link
Member Author

FYI @voidCounter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant