Migrate all tests to puppeteer, remove zombie test dependency #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any issue to be resolved? |
|
@OpherM Hello, yes. I just reproduced the hang by running |
shakeelmohamed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is likely a breaking change in mocha since v7 which is causing the tests to hang.
One of those changes is the deprecation of
mocha.opts, though there may be other issues to address.CI will be good to go once the
workflowbranch is merged in, but CI itself will hang until this issue if fixed.A possible solution is replacing zombie with Puppeteer for headless testing