Youtube Playlist URL support #244

apoorvnandan · 2016-09-17T09:55:56Z

Closes #1

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, include the text Closes #1 (where 1 would be the issue number) to your commit message.

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Youtube playlist URLs work after these changes.

We identify the playlist id from the url and retrieve its items using Youtube API.
Then to play the first item of the playlist when we call makeListenURL(), we make it append the playlist id and index of the item as parameters in the url. (for example: http://localhost:8080/?v=PT2_F-1esPk&playlistindex=0&playlistid=PLx0sYbCqOb8TBPRdmBHs5Iftvv9TPboYG)
I added an eventlistener for when the song/video ends. What it does is if the current URL contains playlist id and playlist index as parameters, it calls makeListenURL() again so that it can make a new URL with the videoID and playlist index parameters changed to that of the next video in the playlist (if the playlist has not ended)
(for example, http://localhost:8080/?v=PT2_F-1esPk&playlistindex=0&playlistid=PLx0sYbCqOb8TBPRdmBHs5Iftvv9TPboYG changes to http://localhost:8080/?v=UprcpdwuwCg&playlistindex=1&playlistid=PLx0sYbCqOb8TBPRdmBHs5Iftvv9TPboYG

One expected problem is that the Youtube API gives us the playlist items in paginated form, so we get a maximum of 50 items at a time and then we have to call the API again. I have not yet addressed this and so if the playlist contains more than 50 items, we get the first 50 items only.

Update from original

…o-player.github.io

shakeelmohamed

the Youtube API gives us the playlist items in paginated form, so we get a maximum of 50 items at a time and then we have to call the API again.

You can take a bit of the solution from watchLater() on YouTube Watch later.

shakeelmohamed · 2016-09-18T23:19:13Z

js/zap-common.js

@@ -39,6 +39,21 @@ function getYouTubeVideoDescription(videoID, youTubeDataApiKey, onSuccess, onFai
    }).fail(onFail);
 }

+function getYouTubeListItems(listID, youTubeDataApiKey, onSuccess, onFail) {
+    // Request the video description


This comment is not accurate

shakeelmohamed · 2016-09-18T23:22:38Z

js/zap-common.js

@@ -47,10 +62,17 @@ function parseYoutubeVideoID(url) {
    };
    var shortUrlDomain = "youtu.be";
    var longUrlDomain = "youtube.com";
+    var playlistUrlElement = "&list=";


We need to be smarter about this, list could be the first query parameter - represented as ?list=foo.
We should be able to check the return value of getParameterByName(url, "list") against being null, which means it's not in the URL.

Also, this means we don't have to declare this variable and it'll simplify the code below

shakeelmohamed · 2016-09-18T23:24:23Z

js/everything.js

+    }
+    else {
+        console.log("loading song");
+        if(window.location.href.indexOf("playlistid=") !== -1) isPlayingPlaylist = true;


I don't think this line has any effect

shakeelmohamed · 2016-09-18T23:25:42Z

js/everything.js

+    if(isPlayingPlaylist) {
+        url += "&playlistindex=" + currentListIndex + "&playlistid=" + currentListID;
+    }
+    else {


This else is noop

shakeelmohamed · 2016-09-18T23:26:10Z

js/everything.js

@@ -377,6 +421,11 @@ function getCurrentVideoID() {
    return v;
 }

+function getCurrentListID() {
+    var v = getParameterByName(window.location.search, "list");


v is a bad variable name here

shakeelmohamed · 2016-09-18T23:27:58Z

js/everything.js

+        return xmlHttp.responseText;
+}
+
+function loadList(listID) {


This is necessarily complicated, let's move this logic to zap-common.js and use the same format as the jQuery HTTP requests.

shakeelmohamed · 2016-09-18T23:32:26Z

js/everything.js

+var listData;
+var isPlayingPlaylist = false;
+
+function getSource(url) {


After refactoring loadList() this function can go away

shakeelmohamed

This is a good start. I think we can just use the same query arg names as YouTube - so playlistindex can be list and playlistid can be id

apoorvnandan · 2016-09-28T16:22:46Z

I have made most of the changes you requested.
Currently working on

You can take a bit of the solution from watchLater() on YouTube Watch later.

I made a separate name playlistindex instead of list because the function parseYoutubeVideoID in zap-common.js identifies playlist ID by the parameter list. playlistid can be changed to id.

shakeelmohamed · 2016-09-30T18:19:47Z

@apoorvnandan Let's get the code cleaned up so Travis CI can run tests. Click the details link on the codeclimate check above

apoorvnandan · 2016-09-30T20:17:41Z

How do I resolve the codeclimate issue

"getYouTubeListItems" is not defined.

The function is defined in zap-common.js along with other functions like parseYoutubeVideoID which do not raise similar issue in codeclimate.

shakeelmohamed · 2016-09-30T21:41:11Z

@apoorvnandan at the top of everything.js there's a list of ignored identifiers that are declared in zap-common.js, add getYouTubeListItems to this list

shakeelmohamed · 2016-10-01T19:43:50Z

After some manual tests this works pretty well @apoorvnandan!
However, I think there's some missing functionality.

Fetching the full playlist (which you're working on)
Pasting the full playlist URL in search box should start the playlist - seeing "error no results"
We should show the upcoming playlist items, maybe even the ones we've already played
The link on the title should include the playlist ID (include the list and index query string args)

FYI Travis CI won't run tests until the merge conflicts are resolved, so no worries there.

shakeelmohamed · 2019-02-13T05:59:04Z

Closing due to inactivity

apoorvnandan and others added 4 commits May 2, 2016 04:02

Merge pull request #1 from zen-audio-player/master

c9a07e6

Update from original

Merge branch 'master' of https://github.com/zen-audio-player/zen-audi…

a5b0292

…o-player.github.io

Playlist URL Support

2362d30

Playlist URL Support Closes #1

630f52f

shakeelmohamed reviewed Sep 18, 2016

View reviewed changes

shakeelmohamed requested changes Sep 18, 2016

View reviewed changes

Review changes Closes #1

e3d79a3

shakeelmohamed approved these changes Sep 30, 2016

View reviewed changes

shakeelmohamed closed this Sep 30, 2016

shakeelmohamed reopened this Sep 30, 2016

shakeelmohamed added question/discussion in progress labels Sep 30, 2016

Code Cleanup

a2aff5a

code clean up

ea5d364

shakeelmohamed mentioned this pull request Oct 8, 2016

Create A To-Be-Played and Have-Played Queue #229

Open

shakeelmohamed added needs work and removed in progress labels Oct 16, 2017

shakeelmohamed closed this Feb 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Youtube Playlist URL support #244

Youtube Playlist URL support #244

apoorvnandan commented Sep 17, 2016

shakeelmohamed left a comment

shakeelmohamed Sep 18, 2016

shakeelmohamed Sep 18, 2016

shakeelmohamed Sep 18, 2016

shakeelmohamed Sep 18, 2016

shakeelmohamed Sep 18, 2016

shakeelmohamed Sep 18, 2016

shakeelmohamed Sep 18, 2016

shakeelmohamed left a comment

apoorvnandan commented Sep 28, 2016

shakeelmohamed commented Sep 30, 2016

apoorvnandan commented Sep 30, 2016

shakeelmohamed commented Sep 30, 2016

shakeelmohamed commented Oct 1, 2016 •

edited

Loading

shakeelmohamed commented Feb 13, 2019

Youtube Playlist URL support #244

Youtube Playlist URL support #244

Conversation

apoorvnandan commented Sep 17, 2016

Motivation and Context

Types of changes

Description

shakeelmohamed left a comment

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed Sep 18, 2016

Choose a reason for hiding this comment

shakeelmohamed left a comment

Choose a reason for hiding this comment

apoorvnandan commented Sep 28, 2016

shakeelmohamed commented Sep 30, 2016

apoorvnandan commented Sep 30, 2016

shakeelmohamed commented Sep 30, 2016

shakeelmohamed commented Oct 1, 2016 • edited Loading

shakeelmohamed commented Feb 13, 2019

shakeelmohamed commented Oct 1, 2016 •

edited

Loading