LayoutResourceMgr #130
Open
LayoutResourceMgr #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the delay in reviewing this! could you rebase and fix the build failure? |
Pistonight
force-pushed
the
layout_resource_mgr
branch
2 times, most recently
from
a6cf11f
to
15ecc89
Compare
Need open-ead/nnheaders#33 for one extra function, I will rebase again with the lib update |
Pistonight
force-pushed
the
layout_resource_mgr
branch
3 times, most recently
from
003ee5f
to
8db6186
Compare
Pistonight
force-pushed
the
layout_resource_mgr
branch
from
137f40f
to
1fdcd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All LayoutResourceMgr functions should match except for 3 that depend on
euiwhich are undecompiledNeeds open-ead/sead#143 for
sead::EnvUtil::getRegionNeeds #129 for
nn::pl- then the forward decl I added temporarily can be deletedAlso sorted
data_symbols.pyby address and added a script to do thatThis change is