chore: update injector make #2915
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
AustinAbro321
commented
Aug 21, 2024
| @@ -111,9 +111,9 @@ components: | |||
| architecture: amd64 | |||
| files: | |||
| # Rust Injector Binary | |||
| - source: https://zarf-init.s3.us-east-2.amazonaws.com/injector/###ZARF_PKG_TMPL_INJECTOR_VERSION###/zarf-injector-amd64 | |||
| - source: ../../src/injector/target/x86_64-unknown-linux-musl/release/zarf-injector | |||
There was a problem hiding this comment.
This is just changed for testing, will revert this file before merge
AustinAbro321
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Signed-off-by: Austin Abro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the makefile by using cross and gets rid of external dependencies on S3 for building the object.
It does also eliminate the ability to create the injector on an arm64 machine. The arm64 binary can still be created through cross on an amd64 machine.
Checklist before merging