Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up: cb6a82de9dc6 - Repair and improve zammad-backup #370

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Follow-up: cb6a82de9dc6 - Repair and improve zammad-backup #370

merged 1 commit into from
Aug 28, 2023

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Aug 28, 2023

  • Switch back to postgres container for zammad-backup
  • Add command passthrough for more convenient container usage/testing
  • Add default value handling for HOLD_DAYS variable

@mgruner
Follow-up: cb6a82d - Repair and improve zammad-backup.
7266ed1 
- Switch back to postgres container for zammad-backup
- Add command passthrough for more convenient container usage/testing
- Add default value handling for HOLD_DAYS variable
@mgruner
Copy link
Collaborator Author

mgruner commented Aug 28, 2023

The recent refactoring in cb6a82d introduced an issue with the backup: it (mistakenly) switched its container from postgres to the Zammad app container, which causes backups to fail. This PR repairs that problem and adds minor improvements to the backup script.

@mgruner mgruner merged commit 0990e43 into master Aug 28, 2023
8 checks passed
@mgruner mgruner deleted the repair-zammad-backup branch August 28, 2023 10:34
floriankessler pushed a commit to floriankessler/zammad-docker-compose that referenced this pull request Jan 5, 2024
@mgruner @floriankessler
Follow-up: cb6a82d - Repair and improve zammad-backup. (zammad#370)
cd2d7f1 
- Switch back to postgres container for zammad-backup
- Add command passthrough for more convenient container usage/testing
- Add default value handling for HOLD_DAYS variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fliebe92 fliebe92 fliebe92 approved these changes

@MrGeneration MrGeneration Awaiting requested review from MrGeneration

@t-shehab t-shehab Awaiting requested review from t-shehab

@monotek monotek Awaiting requested review from monotek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgruner @fliebe92