Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clone_with_wale): fix script to work with wal-g master #979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterparser
Copy link

@peterparser peterparser commented Feb 29, 2024

While working with a wal-g binary built from master branch and spilo, I found out that the newer version of wal-g uses backup_name instead of name in the output of the command, this change make the script not functional during a restore operation.

The change is pretty straightforward, it's also needed to replace the backup_name word to name to make sure that the dictionary is created accordingly to the rest of the script and to support also older versions of wal-g.

@gabrielmocan
Copy link

No need to work with master anymore as wal-g team just cutted a brand new release.

More on #986

@peterparser
Copy link
Author

No need to work with master anymore as wal-g team just cutted a brand new release.

More on #986

Hi @gabrielmocan, the problem was affecting wal-g master and from what I see in #987 test logs is also affecting this new release.

@gabrielmocan
Copy link

No need to work with master anymore as wal-g team just cutted a brand new release.
More on #986

Hi @gabrielmocan, the problem was affecting wal-g master and from what I see in #987 test logs is also affecting this new release.

There's more work to do in this PR, still a draft. Just wait...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants