Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http middleware functions #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

net/http middleware functions #47

wants to merge 2 commits into from

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Feb 11, 2018

#31 implement all middleware functions to have a NetHTTP alternative

@@ -122,6 +157,24 @@ func UidCheck(at []AccessTuple) func(tc *ginoauth2.TokenContainer, ctx *gin.Cont
}
}

// UidCheckNetHTTP is the net/http version of UidCheck
func UidCheckNetHTTP(at []AccessTuple) ginoauth2.AccessCheckFunctionNetHTTP {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to put this under a different package to not have the NetHTTP part in the function name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a bigger refactoring, because of the dependencies, but yes you are right would be good to do

@szuecs szuecs added the wip label Sep 2, 2019
@szuecs szuecs mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants