Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 3 #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,38 +24,38 @@ can make pull requests to that repo during the Task 3 activity during the lab.
During lab, you should not fork directly from https://github.com/CSC207-2023F-UofT/Lab2.
If you miss the lab and work on this after, you should use this URL though.

- [ ] Make a fork of this repo and clone a local copy (as you did in Lab 1).
- [x] Make a fork of this repo and clone a local copy (as you did in Lab 1).
- Important: make sure to uncheck the option to only fork the main branch, as the repo
contains some branches you will use in this lab.

# TASK 1: Your first branch

- [ ] Create and checkout a new branch called `task_1` using either IntelliJ or the Terminal:
- [x] Create and checkout a new branch called `task_1` using either IntelliJ or the Terminal:
- IntelliJ: `Git -> New branch...`
- Terminal: `git checkout -b task_1`
- After, you can check `git status` or the Log tab of the Git tool window in IntelliJ to see
that you are now on the `task_1` branch.
- [ ] Open the TODO tool window (`View -> Tool Windows -> TODO`) and click on the TASK 1 TODO listed.
- [ ] Complete the TASK 1 TODO and commit your changes to this file (checking off the
- [x] Open the TODO tool window (`View -> Tool Windows -> TODO`) and click on the TASK 1 TODO listed.
- [x] Complete the TASK 1 TODO and commit your changes to this file (checking off the
completed items so far) and `DataTypes.java` (remove the word TODO and your bug fix).
- talk to those around you or your TA, then see the hints at the bottom of the readme if you get stuck.
- [ ] Now, we'll merge the `task_1` branch back into `main`. When merging,
- [x] Now, we'll merge the `task_1` branch back into `main`. When merging,
you need to be currently on the branch you are trying to merge into, so we'll first checkout the main
branch:
- IntelliJ: `Git -> branches... -> main -> Checkout`
- Terminal: `git checkout main`
Note: everything we've done has been local to our repository and have not pushed anything yet.
- [ ] We are back on `main`, so we can now do the merge and complete our work!
- [x] We are back on `main`, so we can now do the merge and complete our work!
- IntelliJ: `Git -> Merge... -> task_1 -> Merge`
- Terminal: `git merge task_1`

You should now see the changes you had made are also in the `main` branch.

- [ ] Now, we'll want to clean up since we are done with our `task_1` branch.
- [x] Now, we'll want to clean up since we are done with our `task_1` branch.
- IntelliJ: `Git -> branches... -> task_1 -> Delete`
- Terminal: `git branch -d task_1`

- [ ] Last step, we'll push our changes to the remote repository to share our work! (As we did in Lab 1.)
- [x] Last step, we'll push our changes to the remote repository to share our work! (As we did in Lab 1.)
- we suggest you check off this last item, commit that change (just right on main is fine;
no need to branch for this little step), then push your code. Check GitHub to ensure you can
see your changes.
Expand All @@ -76,26 +76,26 @@ started working on the recipe in `recipe.md` together, and then each filled in t
what they felt would make the most delicious cake!
You'll notice that your repository already has two branches called `alice` and `bob`.

- [ ] Checkout the `alice` branch.
- [ ] Attempt to merge the `bob` branch into the `alice` branch using either IntelliJ or the Terminal.
- [x] Checkout the `alice` branch.
- [x] Attempt to merge the `bob` branch into the `alice` branch using either IntelliJ or the Terminal.
- You will be prompted to resolve a merge conflict. To do this, you will need to pick and choose which
parts of each recipe to keep.
- Read what either `git` or `IntelliJ` tells you in order to complete the merge process.
- If you do the merge through the Terminal, you will need to edit `recipe.md` to remove all of the
merge conflict symbols which `git` has added to your file. Once done, you will need to `git add` the
`recipe.md` file and `git commit` to finish the merge.
- [ ] Once the merge is complete, delete the `bob` branch.
- [x] Once the merge is complete, delete the `bob` branch.

- [ ] Finally, checkout the `main` branch and merge the `alice` branch in (as we did previously).
- [x] Finally, checkout the `main` branch and merge the `alice` branch in (as we did previously).

Now, you are almost ready to share your recipe with the remote!

# TASK 3

- [ ] Checkout a new branch called `task_3`.
- [ ] Commit any changes that you want to `recipe.md` to improve the recipe.
- [ ] While still on the `task_3` branch, push your code to your remote repository on GitHub.
- [ ] Go to GitHub and you will see an option to make a pull request to the original repo. Make
- [x] Checkout a new branch called `task_3`.
- [x] Commit any changes that you want to `recipe.md` to improve the recipe.
- [x] While still on the `task_3` branch, push your code to your remote repository on GitHub.
- [x] Go to GitHub and you will see an option to make a pull request to the original repo. Make
a pull request and see that it shows up in the original repository that you forked.

Since others will also be making pull requests, we won't *actually* accept any of them for now, but
Expand Down
18 changes: 15 additions & 3 deletions recipe.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,21 @@
- 2 cups all-purpose flour
- 1 3/4 cups granulated sugar
- 3/4 cup unsweetened cocoa powder
- ...
- 1 cup chocolate chips
- 1 tsp vanilla extract
- 1/2 tsp ground cinnamon

## Instructions:
1. Preheat the oven to 350°F (175°C).
2. In a large bowl, whisk together the flour, sugar, and cocoa powder.
3. ...
2. In a large bowl, whisk together the flour, sugar, cocoa powder, chocolate chips, and vanilla extract.
3. Follow the additional directions below...

## Additional Directions by Bob:
4. Add a tablespoon of instant coffee to the dry ingredients for a hint of mocha flavor.
5. Mix in a handful of chocolate chunks for extra indulgence.
6. Line the bottom of the baking pan with parchment paper for easy cake removal.

## Additional Directions by Alice:
4. In a separate bowl, beat the eggs and add them to the mixture. Stir until well combined.
5. Gradually add the milk and vegetable oil to the mixture, continuing to stir.
6. Pour the batter into a greased and floured 9x13-inch baking pan.
4 changes: 2 additions & 2 deletions src/DataTypes.java
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import java.util.List;

public class DataTypes {
// TODO TASK 1: fix this code so that it passes the test in DataTypesTest.java
// TASK 1: fixed this code so that it passes the test in DataTypesTest.java
public static long sum(List<Integer> numbers) {

int s = 0;
long s = 0;
// below is a "foreach" loop which iterates through numbers
for (int x : numbers) {
s += x;
Expand Down