Fix tests

yireo · Aug 9, 2024 · 8778746 · 8778746
1 parent 2196fc8
commit 8778746
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/DataLayer/Tag/Cart/CartValue.php b/DataLayer/Tag/Cart/CartValue.php
@@ -3,8 +3,6 @@
 namespace Yireo\GoogleTagManager2\DataLayer\Tag\Cart;
 
 use Magento\Checkout\Model\Cart as CartModel;
-use Magento\Framework\Exception\LocalizedException;
-use Magento\Framework\Exception\NoSuchEntityException;
 use Yireo\GoogleTagManager2\Api\Data\TagInterface;
 use Yireo\GoogleTagManager2\Util\PriceFormatter;
 

diff --git a/Test/Integration/DataLayer/Event/ViewCartTest.php b/Test/Integration/DataLayer/Event/ViewCartTest.php
@@ -2,6 +2,7 @@
 
 namespace Yireo\GoogleTagManager2\Test\Integration\DataLayer\Event;
 
+use Magento\Checkout\Model\Cart as CartModel;
 use Magento\Framework\App\ObjectManager;
 use Magento\Quote\Api\Data\CartInterface;
 use PHPUnit\Framework\TestCase;
@@ -25,14 +26,15 @@ class ViewCartTest extends TestCase
      */
     public function testValidViewCartEvent()
     {
-        $this->markTestSkipped('Broken test');
         $om = ObjectManager::getInstance();
         $cart = $om->create(CartInterface::class);
 
         $product = $this->createProduct(1);
         $item = $cart->addProduct($product);
         $item->setQty(2);
         $cart->setItems([$item]);
+        $cart->setSubtotal(42.0);
+        $om->get(CartModel::class)->setQuote($cart);
 
         $this->assertNotEmpty($cart->getItems());
         $this->assertCount(1, $cart->getItems());
@@ -43,7 +45,9 @@ public function testValidViewCartEvent()
         $data = $viewCartEvent->get();
         $this->assertTrue($data['meta']['cacheable']);
         $this->assertEquals('view_cart', $data['event']);
-        $this->assertNotEmpty($data['ecommerce']['items']);
+        $this->assertEquals('USD', $data['ecommerce']['currency']);
+        $this->assertNotEquals(0.0, $data['ecommerce']['value']);
+        $this->assertNotEmpty($data['ecommerce']['items'], 'No ecommerce items found');
         $this->assertEquals(2, (int)$data['ecommerce']['items'][0]['quantity']);
     }
 }
diff --git a/Test/Integration/Page/AddToWishlistTest.php b/Test/Integration/Page/AddToWishlistTest.php
@@ -21,8 +21,10 @@ class AddToWishlistTest extends PageTestCase
 
     /**
      * @magentoDbIsolation disabled
+     * @magentoAppIsolation disabled
      * @magentoAppArea frontend
      * @magentoDataFixture Magento/Catalog/_files/product_simple.php
+     * @magentoConfigFixture current_store cataloginventory/options/show_out_of_stock 1
      * @return void
      * @throws LocalizedException
      * @throws NoSuchEntityException
@@ -34,6 +36,8 @@ public function testAddToWishlist()
 
         $productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
         $product = $productRepository->get('simple');
+        $product->setData('is_saleable', 1);
+        $productRepository->save($product);
 
         $wishlist = $this->getWishlist();
         $this->assertEquals(0, $wishlist->getItemsCount());
@@ -42,6 +46,7 @@ public function testAddToWishlist()
         $request = $this->getRequest();
 
         $request->setPostValue([
+            'wishlist_id' => $wishlist->getId(),
             'product' => $product->getId(),
             'formKey' => $this->objectManager->get(FormKey::class)->getFormKey(),
         ]);