Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more specific psalm type for result of StringHelper::base64UrlEncode() method #128

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 17, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Mar 17, 2024

PR Summary

  • Enhanced type for StringHelper::base64UrlEncode() method results
    This change allows better identification of results returned from the StringHelper::base64UrlEncode() method by assigning a more specific psalm type. This tweak helps in better understandability and handling of the function outputs.

  • Introduced an additional test case for base64UrlEncodedStringsProvider()
    An empty string test case was added to the base64UrlEncodedStringsProvider() data provider function in the StringHelperTest class. This inclusion will improve our application's robustness by ensuring the function behaves as expected even when provided with an empty string input.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2.x@1ffc263). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             2.x     #128   +/-   ##
======================================
  Coverage       ?   99.76%           
  Complexity     ?      149           
======================================
  Files          ?        7           
  Lines          ?      428           
  Branches       ?        0           
======================================
  Hits           ?      427           
  Misses         ?        1           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit da1a178 into 2.x Mar 17, 2024
23 checks passed
@vjik vjik deleted the improve-psalm-type branch March 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants