Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of $strict parameter in Inflector::toSnakeCase() to false #123

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 6, 2024

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Fix #112

@vjik vjik changed the base branch from 2.x to 3.x January 6, 2024 14:25
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (3.x@bb181b2). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             3.x     #123   +/-   ##
======================================
  Coverage       ?   99.76%           
  Complexity     ?      149           
======================================
  Files          ?        7           
  Lines          ?      428           
  Branches       ?        0           
======================================
  Hits           ?      427           
  Misses         ?        1           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 6, 2024

PR Summary

  • Version number update
    The project version has been revised from 2.4.1 to 3.0.0, as mentioned in the CHANGELOG.md file, which keeps track of the changes in each version of the software.

  • Inflector method update
    We updated the methodology of turning different kinds of text into 'snake case' – a standard programming format – making it an optional strict application rather than a default. This evolution changes the $strict parameter in the Inflector::toSnakeCase() function from true to false.

  • Upgrade and Test instructions update
    The instructions for upgrading from 2.x version to 3.x is updated to account for the changes we've made. This includes guidance to modify any existing code that uses the Inflector::toSnakeCase() function to respect the new default value. Also, the subsequent tests used to ensure that our code is functioning correctly have also been updated to reflect this change.

  • Test data enhancement
    New test cases have been established to ensure that both the old and new functionality of converting text into 'snake case' works as expected, further ensuring the integrity and usability of the code.

@vjik vjik requested a review from a team January 6, 2024 14:26
@vjik vjik added the status:code review The pull request needs review. label Jan 6, 2024
@vjik vjik merged commit 5b74049 into master Jan 7, 2024
22 of 23 checks passed
@vjik vjik deleted the fix-112 branch January 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default value of $strict parameter in Inflector::toSnakeCase() to false
2 participants