-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auth through ydb-go-sdk in communication with YDB cluster #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Thank you for contributing! |
artgromov
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Improve this Pull Request to support common types for authorization in communication with YDB cluster.
It is now possible to use field
enable enforce_static_user_credentials: true
in configuration YAML. YDB operator support 3 types of auth: anonymous (by default), access_token (oauth) and static credentials (username/password). Default password are using at init new cluster storage process if other not specified (just do not specify password field).In general ydb-operator obtain a token from
secretKeyRef
from Storagespec.operatorConnection
section and use that in following communication with YDB (for example in healthcheck and create tenant methods)Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Not possible to specify
enforce_static_user_credentials
Operator uses shell-in-pod-execution, raw grpc and ydb-go-sdk to communicate with YDB
Issue Number: YDBOPS-6056 (about static creds in general), YDBOPS-6646 (enforce_static_user_credentials fix), YDBOPS-7373 (support authorization common types for ydb-operator)
What is the new behavior?
enforce_static_user_credentials
, operator correctly issues commands to YDB, using a token which it obtains from ydb-go-sdk. No raw grpc!Other information
Refactoring: