feat: settings usage in requests and modification... #1060 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
force-pushed
the
astandrik.settings-usage-and-modification
branch
2 times, most recently
from
4af9fe8
to
c40698f
Compare
astandrik
commented
Jul 26, 2024
astandrik
added a commit
to astandrik/ydb
that referenced
this pull request
Jul 29, 2024
astandrik
force-pushed
the
astandrik.settings-usage-and-modification
branch
3 times, most recently
from
62f873c
to
a5ae84b
Compare
|
Settings are not changed, when I click save button in Dialog, and not applied to requests |
I think you should clear cache for this stand |
Lets align these two icons
|
Raubzeug
requested changes
Jul 30, 2024
src/containers/Tenant/Query/QueryEditorControls/utils/getChangedQueryExecutionSettings.ts
Outdated
Show resolved
Hide resolved
...ainers/Tenant/Query/QueryEditorControls/utils/getChangedQueryExecutionSettingsDescription.ts
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx
Outdated
Show resolved
Hide resolved
artemmufazalov
requested changes
Jul 30, 2024
|
fixed |
astandrik
force-pushed
the
astandrik.settings-usage-and-modification
branch
from
d5bfcd9
to
29917f9
Compare
artemmufazalov
requested changes
Jul 31, 2024
astandrik
force-pushed
the
astandrik.settings-usage-and-modification
branch
from
29917f9
to
d125642
Compare
artemmufazalov
previously approved these changes
Jul 31, 2024
Raubzeug
requested changes
Jul 31, 2024
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Query/QuerySettingsBanner/QuerySettingsBanner.tsx
Outdated
Show resolved
Hide resolved
Raubzeug
previously approved these changes
Jul 31, 2024
Raubzeug
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1060
Please Turn Experiment ON via browser console before testing!
Stand
Please Turn Experiment OFF via browser console after testing!
to turn experiment ON use
to turn experiment OFF use