Handle migration partition non-retriable errors separately #2142
+336
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komarevtsev-d
previously approved these changes
Sep 27, 2024
qkrorlqr
reviewed
Sep 27, 2024
cloud/blockstore/libs/storage/partition_nonrepl/part_nonrepl_migration_actor.cpp
Outdated
Show resolved
Hide resolved
qkrorlqr
reviewed
Sep 27, 2024
cloud/blockstore/libs/storage/partition_nonrepl/part_nonrepl_events_private.h
Outdated
Show resolved
Hide resolved
qkrorlqr
reviewed
Sep 27, 2024
cloud/blockstore/libs/storage/partition_nonrepl/part_nonrepl_migration_ut.cpp
Outdated
Show resolved
Hide resolved
drbasic
commented
Sep 30, 2024
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| void TNonreplicatedPartitionMigrationCommonActor::ScheduleRangeMigration( | ||
| const TActorContext& ctx) | ||
| { | ||
| if (RangeMigrationScheduled || IsIoDepthLimitReached()) { | ||
| if (!MigrationEnabled || RangeMigrationScheduled || IsIoDepthLimitReached()) |
There was a problem hiding this comment.
Уточнил условие: нет смысла планировать миграцию диапазона если миграции запрещены.
Это упрощает код, не надо делать проверки перед вызовом ScheduleRangeMigration().
| if (msg->FollowerGotNonRetriableError) { | ||
| OnMigrationNonRetriableError(ctx); | ||
| } | ||
|
|
||
| DrainActorCompanion.ProcessDrainRequests(ctx); | ||
| ScheduleRangeMigration(ctx); |
There was a problem hiding this comment.
так как добавил проверку внутрь ScheduleRangeMigration() могу вызывать ее без проверки что миграции запрещены
komarevtsev-d
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Класс TMirrorRequestActor используется для двух задач:
Здесь делается так, что явно указывается какая реплика является "follower". Если такой реплики нет, то все реплики равнозначные и работа идет по сценарию 1.
Если такая реплика есть, то у нас второй сценарий и поведение чуть меняется относительно того что было: