Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-2076: fix affected disk tracking #2092

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

issue-2076: fix affected disk tracking #2092

wants to merge 4 commits into from

Conversation

sharpeye
Copy link
Collaborator

@sharpeye sharpeye added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d290bdb.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3281 3281 0 0 0 0

@sharpeye sharpeye marked this pull request as ready for review September 20, 2024 16:51
@sharpeye sharpeye marked this pull request as draft September 20, 2024 16:57
@sharpeye sharpeye changed the title issue-2076: device replacement refactoring issue-2076: fix affected disk tracking Sep 20, 2024
@sharpeye sharpeye added the bug Something isn't working label Sep 20, 2024
@sharpeye sharpeye force-pushed the users/sharpeye/issue-2076-fix-device-replacement branch from 2085b8c to 2fa0ae6 Compare September 20, 2024 20:45
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 2fa0ae6.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3282 3282 0 0 0 0

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2076-fix-device-replacement branch 2 times, most recently from 8fb718d to fce1c9e Compare September 23, 2024 15:21
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit fce1c9e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3283 3283 0 0 0 0

@sharpeye sharpeye marked this pull request as ready for review September 23, 2024 17:28
@sharpeye sharpeye force-pushed the users/sharpeye/issue-2076-fix-device-replacement branch from fce1c9e to b698180 Compare September 24, 2024 16:23
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b698180.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3283 3283 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 26e4c32.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3283 3283 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5955e1e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3284 3284 0 0 0 0

qkrorlqr
qkrorlqr reviewed Sep 26, 2024
View reviewed changes
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
@@ -1149,11 +1149,50 @@ NProto::TError TDiskRegistryState::ReplaceDevice(
bool manual,
bool* diskStateUpdated)
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай эту ф-цию тогда переименуем в ReplaceDeviceAndUpdateDiskStateIfNeeded

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReplaceDevice - публичная функция, для неё предполагается, что она всё применит.
Давай переименую приватную в ReplaceDeviceWithoutDiskStateUpdate - чтобы понятнее было?

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2076-fix-device-replacement branch from ac05095 to fe299e6 Compare September 27, 2024 11:09
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit fe299e6.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3284 3284 0 0 0 0

@sharpeye sharpeye force-pushed the users/sharpeye/issue-2076-fix-device-replacement branch from fe299e6 to 578f58a Compare September 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbasic drbasic Awaiting requested review from drbasic

@qkrorlqr qkrorlqr Awaiting requested review from qkrorlqr

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharpeye @qkrorlqr