Fix display of special characters in finder popups #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously len( desc ) and len( path ) counted bytes, which was wrong for non-ascii characters. A string like `čđš` should have the length of 3 when calculating the number of spaces between the identifier and the file path. That brings us to choosing the right string length function. The choices are: - strcharlen - counts grapheme clusters. `čđš` is 3, `čđ\tš` is 4. - strdisplaywidth - counts character width on screen. `čđš` is 3 and `čđ\tš` is 9 (assuming `tabstop` is 8). Tabs do not appear in identifier names, but double width emojis might? Tabs *can* appear in file names though. If there's more than one tab in the file name, using `strcharlen` will push the file path text off screen.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4215 +/- ##
==========================================
+ Coverage 89.70% 89.72% +0.02%
==========================================
Files 34 34
Lines 4420 4420
==========================================
+ Hits 3965 3966 +1
+ Misses 455 454 -1 |
puremourning
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
Previously len( desc ) and len( path ) counted bytes, which was wrong for non-ascii characters. A string like
čđšshould have the length of 3 when calculating the number of spaces between the identifier and the file path.That brings us to choosing the right string length function. The choices are:
čđšis 3,čđ\tšis 4. Not sure what happens in the face of zero width joiners.čđšis 3 andčđ\tšis 9 (assumingtabstopis 8).Tabs do not appear in identifier names, but double width emojis might? Tabs can appear in file names though. If there's more than one tab in the file name, using
strcharlenwill push the file path text off screen.I do not know if there's a performance penalty for using
strdisplaywidthoverstrcharlen.This change is