Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for Hosted Git Dependencies #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Volune
Copy link

@Volune Volune commented Aug 8, 2017

rendered RFC

I was previously trying to make a PR related to these changes, but it was becoming too big. There are still several unresolved questions.

Copy link
Member

@bestander bestander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the RFC, @Volune.

IMHO this one does not need to be that detailed in motivation but more focused what it will break in the current implementation and to what sorts of URLs will be affected


# Detailed design

As a first step, the existing implementation for *hosted* git dependencies should be removed, and patterns that previously matched a hosted dependency should resolve to a git repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you justify why the code for hosted git dependencies should be removed?
Are there specific issues caused by the current implementation?
Can it be just modified?

- a fallback git repository url (to be used if previous urls are not accessible, for example permission issue)

The `Git` utility should be the only place to make a distinction between *hosted* repositories and other repositories.\
If it is a *hosted* repository, the `Git` utility should first try to make HTTPS requests, then fallback on using the `git` command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some examples for the workflow?

The most important part of this RFC is to identify the rules for hosted/regular git dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants