Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for math span calculation #785

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

toothache
Copy link

@toothache toothache commented Mar 20, 2024

A follow up fix for #779 . Math span end position should also consider the situation when the math inline is closed with whitespace.

@xoofx
Copy link
Owner

xoofx commented Mar 25, 2024

I'm not sure what exactly the fix for set text heading is trying to address. The following seems to be correct for CommonMark implementations, including markdig.

@toothache
Copy link
Author

toothache commented Mar 25, 2024

I'm not sure what exactly the fix for set text heading is trying to address. The following seems to be correct for CommonMark implementations, including markdig.

markdig is parsing the second set text heading with an extra character as heading. But it shouldn't, correct?

As shown below, commonmark and markdig have different behaviors parsing the second set text heading.

...
commonmark-java 0.13.0Java
commonmark.js 0.28.1Javascript
league/commonmark GFM 2.4.0Php
league/commonmark 2.4.0Php
...

<h1>
  Hello
</h1>
<p>
  Test ===n
</p>

Results 1 implementation#4
markdig 0.35.0.0C#

<h1>
  Hello
</h1>
<h1>
  Test
</h1>

@xoofx
Copy link
Owner

xoofx commented Mar 26, 2024

markdig is parsing the second set text heading with an extra character as heading. But it shouldn't, correct?

Sorry, completely misread babelmark results. You are absolutely correct.

xoofx added a commit that referenced this pull request Mar 26, 2024
@toothache toothache changed the title Fix issues for math span calculation and setext heading parsing Fix issues for math span calculation Mar 26, 2024
@xoofx xoofx merged commit 8e22754 into xoofx:master Mar 29, 2024
1 check passed
@xoofx
Copy link
Owner

xoofx commented Mar 29, 2024

Thanks!

@xoofx xoofx added the bug label Mar 29, 2024
@toothache
Copy link
Author

Thanks!

Hi, @xoofx . Is it possible to release a new version containing the fix? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants