Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start time when buffer is repeated. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xloem
Copy link

@xloem xloem commented Mar 29, 2018

@xmikos this fixes a bug where incorrect start times are written when the integration buffer exceeds the max buffer size

Resolves a bug where, if max buffer size is exceeded, the output start time will be overwritten in the loop, and stored as much later than it really is.
@xloem
Copy link
Author

xloem commented Apr 8, 2018

@xmikos I was wondering if you'd have time to merge or address this simple fix?

Prior to this adjustment, I don't believe the start time of a large sweep is recorded at all.

@xloem
Copy link
Author

xloem commented Apr 14, 2018

hey @xmikos ; you commented on a PR a bit ago, but you've been silent for a while now. I was wondering if there is anything I could do to help move some of my PR's forward, or if there is some time frame within which you'd have time to address them? If I don't hear from you, I'll try to check back in a month.

@xloem
Copy link
Author

xloem commented Jun 19, 2018

@xmikos just sending you a ping; I could clean up these pull requests but if this project is no longer maintained at all I'll fork it or pick a different one

@xmikos
Copy link
Owner

xmikos commented Jun 19, 2018

@xloem I am still around, just my family and job eaten all of my free time. I have planned to get back to my SDR projects about 3 months ago, but it didn't pan out well then. Now I should have more time again, I want to go through all Pull Requests next week and then release new version. It should be better with my time for SDR projects after that. So I gladly please you to be little more patient. I am fully aware it has been really long time, sorry :-(

@xloem
Copy link
Author

xloem commented Jun 19, 2018

@xmikos thanks for the update =) Once you have time, it would be great if you could look at just this PR in particular. It is very simple and fixes a bug for me.

@RileyThomasPhillips
Copy link

Hey @xmikos I'm a friend of @xloem and was also wondering about this pull request in particular. Sorry to bother you, I know you mentioned family and work has kept you busy, but I am curious if you've made any progress recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants