Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of obsolete code (resolves CA-375774). #3253

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Removal of obsolete code (resolves CA-375774). #3253

merged 5 commits into from
Dec 4, 2023

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Nov 3, 2023

Please review each commit separately.

@kc284
Remove code handling old style patches (also resolves CA-375774).
c1c34bc 
Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284
Converted public fields to properties and renamed two of them.
59c57e2 
Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284
Removed class XenServerPatchMapping since now there is only one subcl…
9743c46 
…ass.

Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284
Removed old and compacted remaining RPU hotfix code:
53bfc7b 
- Removed obsolete MultipleHotfix class.
- Merged HotfixFactory, SingleHotfix, and Hotfix classes to one RpuHotfix class.
- Create a dedicated action for applying RPU hotfixes.

Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284 kc284 added the ITE PR should be reviewed within this iteration label Nov 4, 2023
@kc284 kc284 self-assigned this Nov 4, 2023
@danilo-delbusso danilo-delbusso added needs answer PR contains question that needs to be answered needs updating A reviewer has requested changes labels Nov 13, 2023
@danilo-delbusso
Copy link
Member

danilo-delbusso commented Nov 13, 2023 •
edited
Loading

Also found a bunch of Messages.resx updates we might want to make:

Rename

Messages.REMOVE_PATCH -> Rename to REMOVE_UPDATE
Messages.SUPP_PACK_UPLOADING -> Rename to "UPLOADING_FILE"

Remove, not used anymore

REMOVING_UPDATE
REMOVED_UPDATE
ACTION_CHECK_DISK_SPACE_TITLE
ACTION_CHECK_DISK_SPACE_DESCRIPTION
ACTION_CLEANUP_DISK_SPACE_SUCCESS
ACTION_CLEANUP_DISK_SPACE_TITLE
ACTION_CLEANUP_DISK_SPACE_DESCRIPTION
UPDATES_WIZARD_APPLYING_UPDATE_MULTIPLE_HOSTS
ALL_UPDATES_APPLIED
SUPP_PACK_INSTALL_FAILED
UPDATES_WIZARD_REMOVING_UPDATE

@kc284
Corrections as per code review.
8662eb4 
Signed-off-by: Konstantina Chremmou <[email protected]>
@danilo-delbusso danilo-delbusso added updated Changes completed, please review and removed needs updating A reviewer has requested changes needs answer PR contains question that needs to be answered labels Nov 22, 2023
@kc284 kc284 added ASAP PR should be reviewed as soon as possible and removed ITE PR should be reviewed within this iteration labels Dec 4, 2023
danilo-delbusso
danilo-delbusso approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@danilo-delbusso danilo-delbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilo-delbusso danilo-delbusso added 1 approval PR has been approved by one reviewer and removed updated Changes completed, please review labels Dec 4, 2023
@CitrixChris CitrixChris added 2 approvals PR has been approved by two reviewers and removed 1 approval PR has been approved by one reviewer labels Dec 4, 2023
@kc284 kc284 merged commit 5ae6bbb into xenserver:feature/cdn-updates Dec 4, 2023
1 check passed
@kc284 kc284 deleted the feature/cdn-updates-1 branch December 4, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-delbusso danilo-delbusso danilo-delbusso approved these changes

@CitrixChris CitrixChris CitrixChris approved these changes

Assignees

@kc284 kc284

Labels
2 approvals PR has been approved by two reviewers ASAP PR should be reviewed as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kc284 @danilo-delbusso @CitrixChris