CP-45226: Added friendly name for new datasource 'hostload' #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Chremmou <[email protected]>
CitrixChris
approved these changes
Oct 24, 2023
DeliZhangX
reviewed
Oct 25, 2023
XenModel/FriendlyNames.resx
Outdated
| @@ -1856,6 +1856,9 @@ | |||
| <data name="Message.name-wlb_vm_relocation" xml:space="preserve"> | |||
| <value>WLB VM Relocation</value> | |||
| </data> | |||
| <data name="OPERATIONAL_METRICS_HOSTLOAD" xml:space="preserve"> | |||
| <value>CPU Load</value> | |||
There was a problem hiding this comment.
Looks this will show on UI. So I suggest to use "Host Load" or "Host CPU Load" that keeps same style to Control Domain Load for loadavg
There was a problem hiding this comment.
Yeah, I was wondering about that, then I thought I'd drop the "Host" bit because we don't use it in the other host CPU datasources, but I'll add it back. Thanks.
There was a problem hiding this comment.
Since it's similar to loadavg I also changed the category type shown by the UI.
danilo-delbusso
requested changes
Oct 25, 2023
Signed-off-by: Konstantina Chremmou <[email protected]>
kc284
added
updated
danilo-delbusso
added
2 approvals
kc284
removed
under review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.