Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fix #215

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Misc fix #215

wants to merge 3 commits into from

Conversation

chenhengqi
Copy link
Contributor

@chenhengqi chenhengqi commented May 3, 2021

  1. code cleanup(comments, unused codes, indention etc.)
  2. sync with latest libbpf, replace deprecated API usage and fix memory leak.

@tohojo
Copy link
Member

tohojo commented May 4, 2021

Please drop the first commit; it's a tutorial, so it's not really supposed to
work out of the box...

@chenhengqi
Copy link
Contributor Author

Done.

But it's strange that everyone cloning this repo has to resolve the compilation error before getting a successful build.

@tohojo
Copy link
Member

tohojo commented May 4, 2021 via email

@chenhengqi
Copy link
Contributor Author

I use clang-13, it fails. (clang 11/12 works fine.)

@tohojo
Copy link
Member

tohojo commented May 4, 2021 via email

@chenhengqi
Copy link
Contributor Author

I believe it's a new flag in clang, no Google search results and documents for it currently.

It doesn't work in clang-12.

error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
make[1]: *** [../common//common.mk:111: xdp_prog_kern.o] Error 1
make[1]: Leaving directory '/home/xdp-tutorial/basic03-map-counter'
make: *** [Makefile:13: basic03-map-counter] Error 2

@tohojo
Copy link
Member

tohojo commented May 6, 2021 via email

@tohojo
Copy link
Member

tohojo commented May 6, 2021 via email

@chenhengqi
Copy link
Contributor Author

I update to the latest nightly version, no complaints now.

How about just forget it and come back when it lands or clang-13 release ?

@tohojo
Copy link
Member

tohojo commented May 6, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants